Calculating factorials opens the doors to a discussion about stack overflow (if done recursively) and integer overflow (if the param is too large) as well as discussions around how to handle and catch errors.
using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
namespace Factorial
{
class Program
{
static void Main(string[] args)
{
//Find the factorial of a given integer
int n = 6;
int factor = RecursiveFactorial(n);
Console.WriteLine("Recursive factorial result : {0}",factor);
int factorInterative = IterativeFactorial(n);
Console.WriteLine("Iterative factorial result : {0}", factorInterative);
Console.ReadKey();
}
public static int RecursiveFactorial(int n)
{
if (n <= 1)
return 1;
else if (n>=1)
{
try
{
return n * RecursiveFactorial(--n);
}
catch (Exception ex)
{
}
}
return 1;
}
public static int IterativeFactorial(int n)
{
if (n <= 0)
return 0;
int factor = 1;
try
{
for (int i = 1; i <= n; i++)
{
factor *= i;
}
return factor;
}
catch (Exception ex)
{
}
return 1;
}
}
}
1 comment:
You don't need to catch the exceptions if you are only re-throwing them.
Also, the n<=1 and n>=1 both handle n=1 and the common return is also 1 - I think you can just leave the return 1 and change the else to an if and remove the first if and it should still work the same.
In the iterative approach, if you return 0, then the entire factorial will be 0, so you should handle that at 1 just like in the recursive method.
Post a Comment